Re: Fix bug of clearing of waitStart in ProcWakeup()

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: ji xu <thanksgreed(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix bug of clearing of waitStart in ProcWakeup()
Date: 2026-02-26 01:04:01
Message-ID: 73B94181-ED28-4BFD-9FF4-20D236DCEBA4@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Feb 26, 2026, at 08:08, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Wed, Feb 25, 2026 at 7:03 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>>
>>
>>
>>> On Feb 24, 2026, at 23:41, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>>
>>> On Tue, Feb 24, 2026 at 4:31 PM ji xu <thanksgreed(at)gmail(dot)com> wrote:
>>>>
>>>>
>>>> Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> 于2026年2月24日周二 14:29写道:
>>>>>
>>>>> Since this function is clearly operating on the parameter proc, the only statement that touches MyProc looks suspicious. It should reset proc->waitStart, not MyProc->waitStart.
>>>>>
>>>>> As written, it will incorrectly clear the caller’s waitStart instead of the awakened backend’s, potentially leaving a stale waitStart value in the target PGPROC.
>>>
>>> Thanks for the report!
>>>
>>
>> I just realized that I forgot to attach the patch file. Anyway, that’s just a one-line change.
>
> I've pushed the patch. Thanks!
>
> Regards,
>
> --
> Fujii Masao

Hi Fujii-san, thank you very much for taking care of this patch.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-02-26 01:13:01 Re: amcheck: fix bug of missing corruption in allequalimage validation
Previous Message Fujii Masao 2026-02-26 00:08:58 Re: Fix bug of clearing of waitStart in ProcWakeup()