| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: REINDEX CONCURRENTLY 2.0 |
| Date: | 2019-03-28 08:07:59 |
| Message-ID: | 7380711553760479@iva5-0acfc31d2b43.qloud-c.yandex.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
Unfortunately patch does not apply due recent commits. Any chance this can be fixed (and even committed in pg12)?
>> And few questions:
>> - reindexdb has concurrently flag logic even in reindex_system_catalogs, but "reindex concurrently" can not reindex system catalog. Is this expected?
>
> If support is ever added, then reindexdb supports it automatically. It
> seems simpler to not have to repeat the same checks in two places.
ok, reasonable for me
>> - psql/tab-complete.c vs old releases? Seems we need suggest CONCURRENTLY keyword only for releases with concurrently support.
>
> It seems we don't do version checks for tab completion of keywords.
Hmm, yes, i found only few checks for "create trigger" syntax about "EXECUTE FUNCTION"/"EXECUTE PROCEDURE" difference in 11
regards, Sergei
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nagaura, Ryohei | 2019-03-28 08:36:10 | RE: Timeout parameters |
| Previous Message | David Rowley | 2019-03-28 07:48:47 | Re: COPY FROM WHEN condition |