Re: Query jumbling ignores XML names, ROLLUP/CUBE, VARIADIC and more

Staroverov Ilja <i(dot)staroverov(at)ftdata(dot)ru> writes:
> While working on the SQL/JSON patterns in pg_stat_statements [1], I
> looked at the other fields marked query_jumble_ignore, and some of them
> change the results of the queries.

I don't believe that query jumbles have ever been intended to
distinguish every semantic detail of a query tree. To the contrary,
merging together "sufficiently similar" queries has always been
precisely the intention. So there is not one of these things that
deserves the label of bug. We can have a discussion about whether
the original (and clearly intentional) choice to mark a field as
query_jumble_ignore was being too aggressive about what is "similar",
but in each case that's going to be a judgment call.

So rather than submitting a patch and expecting it to get pushed,
you need to try to create some consensus on the -hackers list about
whether these things should be changed. To my mind the benefit of
the doubt should probably go to the existing behaviors.

regards, tom lane