Skip site navigation (1) Skip section navigation (2)

Re: Hash Index Build Patch v2

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tom Raney <twraney(at)comcast(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Hash Index Build Patch v2
Date: 2008-03-16 23:23:27
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Tom Raney <twraney(at)comcast(dot)net> writes:
> This revised version of our patch uses the function estimate_rel_size() 
> from plancat.c to estimate the number of tuples in the parent relation.  
> This method is an alternative to scanning the parent relation to 
> estimate the number of tuples, as we did in the first version of the patch.

Applied after significant editorialization.  You need to pay more
attention to conforming to the style of the surrounding code and to
updating comments that your work renders inaccurate.

			regards, tom lane

In response to


pgsql-patches by date

Next:From: Tom LaneDate: 2008-03-17 00:33:47
Subject: Re: sinval.c / sinvaladt.c restructuring
Previous:From: Peter EisentrautDate: 2008-03-14 21:18:22
Subject: Re: Suppress compiler warnings on mingw

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group