| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Importing pg_bsd_indent into our source tree |
| Date: | 2023-02-12 01:43:52 |
| Message-ID: | 736439.1676166232@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Hmmm ... ci autoconf build is now happy, but the Windows run complains
> that none of the output files match. I'm betting that this is a
> Windows-newline problem, since I now see that indent.c opens both the
> input and output files in default (text) mode. I'm inclined to
> change it to open the output file in binary mode while leaving the
> input in text, which should have the effect of stripping \r if it's
> present.
So let's see if that theory is correct at all ...
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Import-pg_bsd_indent-sources.patch | text/x-diff | 186.2 KB |
| v4-0002-Sync-pg_bsd_indent-s-copyright-notices-with-Postg.patch | text/x-diff | 10.2 KB |
| v4-0003-Integrate-pg_bsd_indent-into-our-build-test-infra.patch | text/x-diff | 14.1 KB |
| v4-0004-Add-missing-test-dependency.patch | text/x-diff | 759 bytes |
| v4-0005-Open-output-file-in-binary-mode.patch | text/x-diff | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-02-12 02:14:37 | Re: Importing pg_bsd_indent into our source tree |
| Previous Message | Tom Lane | 2023-02-12 01:32:30 | Re: Importing pg_bsd_indent into our source tree |