Re: Simplify passing of configure arguments to pg_config

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Simplify passing of configure arguments to pg_config
Date: 2019-12-03 05:03:48
Message-ID: 7321.1575349428@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> Currently, configure puts the configure args into the makefiles and
> then have the makefiles pass them to the build of pg_config. That looks
> like an unnecessary redirection, and indeed that method was
> put in place when pg_config was a shell script. We can simplify that
> by having configure put the value into pg_config.h directly. This
> also makes the standard build system match how the MSVC build system
> already does it.

I dunno, is this really an improvement? It makes the handling of
VAL_CONFIGURE different from every other one of the values passed
into pg_config, and I don't see any countervailing addition of
some other regularity. I'm also a bit suspicious of the ad-hoc
escaping step ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Khandekar 2019-12-03 05:39:36 Re: logical decoding : exceeded maxAllocatedDescs for .spill files
Previous Message Etsuro Fujita 2019-12-03 04:13:43 Re: Bogus EXPLAIN results with column aliases for mismatched partitions