Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2019-04-06 14:34:34 -0400, Tom Lane wrote:
>> Why should this code need to free anything? That'd be the responsibility
>> of the slot code, no?
> Well, not really. If a slot doesn't hold heap tuples internally,
> ExecFetchSlotHeapTuple() will return a fresh heap tuple (but signal so
> by setting *should_free = true if not NULL).
Ah, got it: ignoring should_free is indeed a potential issue here.
>> But clearly we need a test case here. I'll adjust Hadi's example
>> so that there's more than one tuple to check, and push it.
> Cool.
Sounds like a plan.
regards, tom lane