Re: enable/disable broken for statement triggers on partitioned tables

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: enable/disable broken for statement triggers on partitioned tables
Date: 2022-05-27 08:11:15
Message-ID: 73027d59-bff7-d245-af90-c654a78a50c0@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 24.05.22 23:23, Zhihong Yu wrote:
> Hi,
>
>     AT_EnableTrig,              /* ENABLE TRIGGER name */
> +   AT_EnableTrigRecurse,       /* internal to commands/tablecmds.c */
>     AT_EnableAlwaysTrig,        /* ENABLE ALWAYS TRIGGER name */
> +   AT_EnableAlwaysTrigRecurse, /* internal to commands/tablecmds.c */
>
> Is it better to put the new enum's at the end of the AlterTableType?
>
> This way the numeric values for existing ones don't change.

That's a concern if backpatching. Otherwise, it's better to put them
like shown in the patch.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2022-05-27 08:25:43 Remove useless tests about TRUNCATE on foreign table
Previous Message Amit Langote 2022-05-27 08:09:46 Re: generic plans and "initial" pruning