| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | HAVE_WORKING_LINK still needed? |
| Date: | 2020-02-28 13:14:51 |
| Message-ID: | 72fff73f-dc9c-4ef4-83e8-d2e60c98df48@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I came across the HAVE_WORKING_LINK define in pg_config_manual.h.
AFAICT, hard links are supported on Windows and Cygwin in the OS
versions that we support, and pg_upgrade already contains the required
shim. It seems to me we could normalize and simplify that, as in the
attached patches. (Perhaps rename durable_link_or_rename() then.) I
successfully tested on MSVC, MinGW, and Cygwin.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pg_standby-Don-t-use-HAVE_WORKING_LINK.patch | text/plain | 1018 bytes |
| 0002-Move-pg_upgrade-s-Windows-link-implementation-to-AC_.patch | text/plain | 6.7 KB |
| 0003-Remove-HAVE_WORKING_LINK.patch | text/plain | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-02-28 13:44:51 | Re: more ALTER .. DEPENDS ON EXTENSION fixes |
| Previous Message | Peter Eisentraut | 2020-02-28 13:02:17 | Re: Add PostgreSQL home page to --help output |