Re: pgsql: Add function to pump IPC process until string match

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: pgsql: Add function to pump IPC process until string match
Date: 2022-03-30 22:00:52
Message-ID: 72D87565-A0A6-42DC-BF0D-3C1E4AFB8237@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 30 Mar 2022, at 18:09, Andres Freund <andres(at)anarazel(dot)de> wrote:

>> Would adding back something like the (right now untested) below be what you're
>> after? Looking at the perldoc I didn't see any other debugging aids we can
>> emit other than the stream and type of error.
>
> I found showing the regex from before useful. Often there's many
> pump_until()'s, and the regex makes it easier to figure out what errored
> out. And it shows quoting problem. Since it only happens when there was a
> failure, it's not like it'll bloat the log unduly.

I'll add diag output on failures along the lines of the diff from earlier today
but with the regex as well (which Alvarao also requested), but tomorrow morning
once coffee has been consumed.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2022-03-30 22:39:43 Re: pgsql: Add 'basebackup_to_shell' contrib module.
Previous Message Robert Haas 2022-03-30 21:44:55 Re: pgsql: Add 'basebackup_to_shell' contrib module.