| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Paul Ramsey <pramsey(at)cleverelephant(dot)ca>, Владимир Лесков <vladimirlesk(at)yandex-team(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, rafia(dot)sabih(at)enterprisedb(dot)com, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Compressed TOAST Slicing |
| Date: | 2019-04-09 17:28:14 |
| Message-ID: | 72B3A29C-E9B3-4CE1-B489-0568E1542929@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> 9 апр. 2019 г., в 22:20, Andres Freund <andres(at)anarazel(dot)de> написал(а):
>
> Just use memmove? It's usually as fast these days.
No, unfortunately, it is fixing things incompatible way.
In pglz side-effects of overlapping addresses are necessary, not the way memmove avoids it.
I.e. bytes
01234
^ copy here three bytes
memmove will give
01012
but we want
01010
^ this 0 is taken from result of overwrite by first byte move.
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-04-09 17:30:22 | Re: Compressed TOAST Slicing |
| Previous Message | Andres Freund | 2019-04-09 17:20:49 | Re: Compressed TOAST Slicing |