Re: Hide 'Execution time' in EXPLAIN (COSTS OFF)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: ronan(at)dunklau(dot)fr, Andres Freund <andres(at)2ndquadrant(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Christoph Berg <cb(at)df7cb(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Markus Wanner <markus(at)bluegap(dot)ch>
Subject: Re: Hide 'Execution time' in EXPLAIN (COSTS OFF)
Date: 2014-10-13 15:46:16
Message-ID: 7297.1413215176@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sun, Oct 12, 2014 at 11:55 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I have no great objection to making both COSTS OFF and TIMING OFF suppress
>> the "planning time" output, if that's the consensus. I would object to
>> taking away that behavior of COSTS OFF, because of the implications for
>> back-patching EXPLAIN queries in regression tests.
>>
>> Another possibility, which would introduce less non-orthogonality into
>> the switch design, is to remove the connection to COSTS OFF but say that
>> planning time is only printed when execution time is also printed (ie,
>> only in EXPLAIN ANALYZE). This seems to me that it would not be removing
>> much functionality, because if you just did a plain EXPLAIN then you can
>> take the client-side runtime (psql \timing) as a close-enough estimate
>> of planning time.

> That'd be fine with me. Making it controlled by COSTS and/or TIMING
> would be OK with me, too. But let's do *something*.

After sleeping on it, the second idea seems cleaner to me: it removes one
wart rather than adding a second one. If there are no objections, I'll
go make it so.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-10-13 15:53:26 Re: Hide 'Execution time' in EXPLAIN (COSTS OFF)
Previous Message Christoph Berg 2014-10-13 15:41:17 Re: Hide 'Execution time' in EXPLAIN (COSTS OFF)