| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Extending outfuncs support to utility statements |
| Date: | 2023-03-19 18:22:10 |
| Message-ID: | 729666.1679250130@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alexander Lakhin <exclusion(at)gmail(dot)com> writes:
> Please look at the function _readA_Const() (introduced in a6bc33019), which fails on current master under valgrind:
> ...
> Here _readA_Const() performs:
> union ValUnion *tmp = nodeRead(NULL, 0);
> memcpy(&local_node->val, tmp, sizeof(*tmp));
> where sizeof(union ValUnion) = 16, but nodeRead()->makeInteger() produced Integer (sizeof(Integer) = 8).
Right, so we can't get away without a switch-on-value-type like the
other functions for A_Const have. Will fix.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Juan José Santamaría Flecha | 2023-03-19 19:10:10 | Re: Fix fseek() detection of unseekable files on WIN32 |
| Previous Message | Melanie Plageman | 2023-03-19 16:48:38 | Re: Should vacuum process config file reload more often |