| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgindent versus struct members and typedefs |
| Date: | 2026-05-06 03:43:39 |
| Message-ID: | 729177.1778039019@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> For fun, I spent some time with an AI tool to develop the attached fix for
> this problem. The explanation seems reasonable to me, although I am by no
> means a pgindent expert. When I looked at this in December, I did find
> this similar commit from upstream [0], but I failed to make the connection
> with last_u_d. 0002 is the result of a pgindent run after applying 0001.
> You'll notice that it fixes the exact set of cases I found with grep
> upthread.
Those changes are clearly improvements. I'm too tired to investigate
right now, but I wonder if we should adopt the upstream fix you
mention? (Or more generally, other changes they made since we forked?)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2026-05-06 03:48:41 | Re: Parallel Apply |
| Previous Message | Alex Guo | 2026-05-06 02:38:32 | Re: Fix DROP PROPERTY GRAPH "unsupported object class" error |