From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Keiichi Hirobe <chalenge(dot)akane(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [patch]overallocate memory for curly braces in array_out |
Date: | 2018-09-24 14:46:42 |
Message-ID: | 727.1537800402@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Keiichi Hirobe <chalenge(dot)akane(at)gmail(dot)com> writes:
> Attached is a patch that fixes a bug
> for miscounting total number of curly braces in output string in array_out.
Wow, good catch!
Testing this, I found there's a second way in which the space calculation
is off: it always allocated one more byte than required, as a result of
counting one more comma than is really required. That's not nearly as
significant as the curly-brace miscount, but it still got in the way of
doing this:
*** 1234,1239 ****
--- 1243,1251 ----
#undef APPENDSTR
#undef APPENDCHAR
+ /* Assert that we calculated the string length accurately */
+ Assert(overall_length == (p - retval + 1));
+
pfree(values);
pfree(needquotes);
which seemed to me like a good idea now that we know this code isn't
so perfect as all that.
Will push shortly.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-09-24 15:39:47 | Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query |
Previous Message | Joe Conway | 2018-09-24 14:17:30 | Re: doc - add missing documentation for "acldefault" |