Re: USE_AUSTRALIAN_RULES breaks regression tests in 7.1.2?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Justin Clift <aa2(at)bigpond(dot)net(dot)au>
Cc: pgsql-general(at)postgresql(dot)org
Subject: Re: USE_AUSTRALIAN_RULES breaks regression tests in 7.1.2?
Date: 2001-06-07 09:49:59
Message-ID: 7257.991907399@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

Justin Clift <aa2(at)bigpond(dot)net(dot)au> writes:
> a) Make the regression tests run in the GMT timezone (+0, no DST, etc) and
> have the expected results also be in GMT.

Not good since that would disable all exercising of DST-related
functionality.

> b) Have an alternate set of results available for the timestamp and horology
> tests, automatically used when the regression tests are run with
> USE_AUSTRALIAN_RULES.

Also not good, from a maintenance standpoint --- we have enough variants
of those files already :-(.

I am inclined to think that treating USE_AUSTRALIAN_RULES as a compile
time option was the wrong idea. It should be a runtime (GUC) option;
then it can be switched off to run the regress tests, regardless of
whether a particular installation keeps it on by default.

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Andrew Gould 2001-06-07 10:40:07 Re: Accessing two differents database in a SELECT
Previous Message Nicolas Huillard 2001-06-07 09:48:24 RE: Accessing two differents database in a SELECT