| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Incorrect comment regarding command completion tags |
| Date: | 2022-10-13 22:38:40 |
| Message-ID: | 72527BF7-9F54-4DA5-9B25-515D290C569B@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Oct 13, 2022, at 2:56 PM, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> I was looking at the code in EndCommand() and noticed a comment
> talking about some Asserts which didn't seem to exist in the code.
> The comment also talks about LastOid which looks like the name of a
> variable that's nowhere to be seen.
>
> It looks like the Asserts did exists when the completion tag patch was
> being developed [1] but they disappeared somewhere along the line and
> the comment didn't get an update before 2f9661311 went in.
>
> In the attached, I rewrote the comment to remove mention of the
> Asserts. I also tried to form the comment in a way that's more
> understandable about why we always write a "0" in "INSERT 0 <nrows>".
Your wording is better. +1
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2022-10-13 22:53:48 | Re: problems with making relfilenodes 56-bits |
| Previous Message | Bruce Momjian | 2022-10-13 22:06:38 | Re: New docs chapter on Transaction Management and related changes |