| From: | Leonardo Francalanci <m_lists(at)yahoo(dot)it> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: use less space in xl_xact_commit patch |
| Date: | 2011-06-16 13:00:15 |
| Message-ID: | 724317.97040.qm@web29013.mail.ird.yahoo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> With regards to the naming, I think it would be better if we kept
> XLOG_XACT_COMMIT record exactly as it is now, and make the second
> record an entirely new record called XLOG_XACT_COMMIT_FASTPATH. That
> way we retain backwards compatibility.
>
> If you'd like to rework like that please, otherwise I can take it from
> here if you'd like.
I think I did it; while doing it, I think I've found a bug: I didn't update
"recoveryStopsHere". Please double check that, as I really don't
know what I'm doing there...
Should I also change the struct name from xl_xact_commit to
xl_xact_commit_fast_path?
> > How can I test it with "weird" stuff as subtransactions, shared
> > cache invalidation messages...?
>
> make installcheck should cover those.
Ok, all tests passed.
| Attachment | Content-Type | Size |
|---|---|---|
| commitlog_lessbytes_v3.patch | application/octet-stream | 20.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2011-06-16 13:17:17 | Re: use less space in xl_xact_commit patch |
| Previous Message | Florian Pflug | 2011-06-16 12:51:50 | Re: Patch - Debug builds without optimization |