Re: pgsql: Rework option set of vacuumlo

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Tue, Aug 28, 2018 at 05:08:25PM -0400, Tom Lane wrote:
>> Oh! The reason why not is that that line is inside "ifdef REGRESS",
>> and these subdirectories have no REGRESS tests. So we should move
>> that out to where it will apply regardless of that. Will fix.

> Yes, I was going to send a patch along the same lines as what you have
> just committed. Thanks! It looks that the binary was installed in my
> own PATH, so I did not notice it.

> This should definitely get back-patched in my opinion, I have similar
> problems with pg_rewind tests of 9.3 and 9.4 that I still maintain out
> of the core tree, where the main binary needs to be installed first. In
> this case I just used some Makefile trick.

I didn't want to backpatch further than v11 without a test case that would
work in those branches, and I lacked one. If you've got out-of-core code
you could verify it with, please do that and back-patch further.

regards, tom lane