| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade: Improve invalid option handling |
| Date: | 2019-06-14 09:03:24 |
| Message-ID: | 722222fa-8a94-fb74-8d92-658b9bcdcec3@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-06-13 14:30, Masahiko Sawada wrote:
> Why do we need to change pg_fatal() to fprintf() & exit()? It seems to
> me that we can still use pg_fatal() here since we write the message to
> stderr.
It just makes the output more consistent with other tools, e.g.,
old:
pg_upgrade: unrecognized option `--foo'
Try "pg_upgrade --help" for more information.
Failure, exiting
new:
pg_upgrade: unrecognized option `--foo'
Try "pg_upgrade --help" for more information.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-06-14 09:36:02 | Re: Update list of combining characters |
| Previous Message | Simon Riggs | 2019-06-14 08:40:53 | Re: Converting NOT IN to anti-joins during planning |