Re: new compiler warnings

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, pgsql(at)j-davis(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: new compiler warnings
Date: 2011-10-18 17:12:15
Message-ID: 7215.1318957935@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I think that what Kevin was on about was something else entirely,
>> namely whether we need to retry writes to disk.

> I would phrase it that we need to *continue* a write to disk if the
> OS chooses to write a portion of it and return to the caller with
> the number actually written. If the first write, or any later
> write, actually gets an error or fails to make progress, *then* we
> should consider the attempt to be done. I don't understand the
> point of not coding to the API.

My point here is just that that's a different discussion. You are not
talking about places where this new compiler warning is getting raised.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2011-10-18 17:16:57 Re: new compiler warnings
Previous Message Robert Haas 2011-10-18 17:08:08 Re: new compiler warnings