| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Emacs vs pg_indent's weird indentation for function declarations |
| Date: | 2019-05-19 19:48:02 |
| Message-ID: | 7214.1558295282@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> writes:
>> Sorry, but GNU indent already uses -kr for something else and I would
>> like FreeBSD indent have something like that under the same name.
>> Besides, indent has too many options and this one doesn't look like
>> particularly desired by anyone. It's possible that someone will complain
>> some day, but I don't think we should assume that they'll do or that
>> they're more important than the other users who benefit from your change
>> being the default behavior and no additional options.
> Huh. OK, I'll rip the switch back out again.
Here's a proposed patch for you.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| improve-function-definition-lookahead.patch | text/x-diff | 9.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Riou | 2019-05-19 20:53:26 | Re: PROXY protocol support |
| Previous Message | Andres Freund | 2019-05-19 18:36:24 | Re: Statistical aggregate functions are not working with PARTIAL aggregation |