| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Windows warnings from VS 2017 |
| Date: | 2017-09-21 13:30:31 |
| Message-ID: | 7214.1506000631@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> The speed of memset is hardly going to be the dominating factor in a
> 'CREATE DATABASE' command, so we could certainly afford to change to
> plain memset calls here.
Another thought is that it may be time for our decennial debate about
whether MemSet is worth the electrons it's printed on. I continue to
think that any modern compiler+libc ought to do an equivalent or better
optimization given just a plain memset(). If that seems to be true
for recent MSVC, we could consider putting an #if into c.h to define
MemSet as just memset for MSVC. Maybe later that could be extended
to other compilers.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-21 13:50:11 | Re: !USE_WIDE_UPPER_LOWER compile errors in v10+ |
| Previous Message | Peter Eisentraut | 2017-09-21 13:30:13 | Re: Re: proposal - psql: possibility to specify sort for describe commands, when size is printed |