Re: pgsql: Provide a TLS init hook

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Provide a TLS init hook
Date: 2020-03-26 01:28:16
Message-ID: 718.1585186096@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 3/25/20 7:44 PM, Tom Lane wrote:
>> I don't actually see why we need the localhost port at all --- it doesn't
>> look like this test ever attempts to connect to the server. So couldn't
>> we just drop that?

> Seems reasonable. I just tested that and it seems quite happy, so I'll
> make the change.

Cool, thanks.

jacana has just exposed a different problem: it's not configured
--with-openssl, but the buildfarm script is trying to run this
new test module anyway. I'm confused about the reason.
"make installcheck" in src/test/modules does the right thing,
but seemingly that client is doing something different?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-03-26 02:05:41 pgsql: Further fixes for ssl_passphrase_callback test module.
Previous Message Andrew Dunstan 2020-03-26 01:18:01 pgsql: Don't listen to localhost in ssl_passphrase_callback test

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Fan 2020-03-26 01:55:35 Re: [PATCH] Keeps tracking the uniqueness with UniqueKey
Previous Message Andrew Dunstan 2020-03-26 01:11:09 Re: pgsql: Provide a TLS init hook