Re: psql history and "-- lines"

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Дилян Палаузов <dpa-postgres(at)aegee(dot)org>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: psql history and "-- lines"
Date: 2017-05-06 23:17:42
Message-ID: 7127.1494112662@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

=?UTF-8?B?0JTQuNC70Y/QvSDQn9Cw0LvQsNGD0LfQvtCy?= <dpa-postgres(at)aegee(dot)org> writes:
> I expect that psql and the shell, e.g. bash, behave in the same way in
> regards to history logs and until-the-current-line comments.

I do not think that the shell necessarily provides a gold-plated precedent
for us to follow. The language syntax it's dealing with is substantially
different from SQL. Even ignoring that point, there are a lot of shell
implementations with a lot of different interactive behaviors; who's to
say that bash is the one true way?

> + rl_variable_bind("comment-begin", "--");

Interesting thought, but IIUC that's a setting that would be better left
to the user's ~/.inputrc, or might indeed override something he's put
there. I'm also dubious how well it works across all the versions of
readline and libedit that are out there.

Perhaps we could document suggested settings for people to put into
~/.inputrc:

$if psql
set comment-begin "-- "
... other things?
$endif

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Дилян Палаузов 2017-05-06 23:40:35 Re: psql history and "-- lines"
Previous Message Дилян Палаузов 2017-05-06 20:31:05 Re: Postgresql and Clang Static Analyzer