Re: make LockRelation use top transaction ID

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: make LockRelation use top transaction ID
Date: 2004-07-24 20:08:19
Message-ID: 7086.1090699699@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> On Fri, Jul 23, 2004 at 09:49:05AM -0400, Tom Lane wrote:
>> No, at least not if you made that a global change. Doing it that way
>> will mean that a failed subtransaction will not release its locks, no?

> Hmm ... won't they be released when the ResourceOwner is released?

Er ... duh. Still stuck in pre-ResourceOwner ways of thinking ;-)

Now that I'm more awake, I recall that I actually considered changing
the lock code to take all locks in the name of the TopTransaction as
part of the ResourceOwner patch. But I decided to leave well enough
alone because I hadn't time to think about all the implications.
Yeah, if you don't see any problem, go for it.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2004-07-24 20:31:05 Re: PreallocXlogFiles
Previous Message Tom Lane 2004-07-24 18:53:50 Re: Nested xact status?