Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Chris Campbell <chris(at)bignerdranch(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c
Date: 2006-10-08 19:39:46
Message-ID: 7084.1160336386@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Chris Campbell <chris(at)bignerdranch(dot)com> writes:
> On Oct 8, 2006, at 14:29, Tom Lane wrote:
>> Looks good, but I don't think we want to abandon OSX 10.2 support
>> just yet. I'll revise this to use a configure probe for dlopen.

> Maybe we can abandon Mac OS X 10.2 in 8.3 and later? And not back-
> port these patches to the 7.x, 8.0, and 8.1 branches?

I don't see any particular reason to abandon 10.2 at all, as long as
all it's costing us is a couple dozen lines in dynloader/darwin.c.
As for back-porting, I don't see a strong reason to do that either.
Apple will presumably maintain the compatibility APIs for a long
while yet.

> BTW, I think the configure probe (only on Darwin, correct?) should
> test for the existence of <dlfcn.h>.

I realized that configure is already probing for dlopen(), so I just
used HAVE_DLOPEN. We can add a separate test for the header file if
it proves really necessary, but I bet it's not.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Page 2006-10-08 20:36:14 Casting to money
Previous Message Magnus Hagander 2006-10-08 19:00:37 Re: The improvement for psql of 8.2beta1 not

Browse pgsql-patches by date

  From Date Subject
Next Message Josh Berkus 2006-10-09 18:43:09 Re: [PATCHES] Generic Monitoring Framework with DTrace patch
Previous Message Chris Campbell 2006-10-08 18:43:28 Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c