> I'm kind of inclined to change uuid_parts_distance to just convert
> a given pg_uuid_t to "double" and then apply penalty_num(), as is
> done in gbt_macad_penalty.
Pushed with that change and some other mostly-cosmetic tweaking.
One not too cosmetic fix was that gbt_uuid_union was declared with the
wrong return type. That's probably mostly harmless given that core GiST
pays little attention to the declared signatures of the support functions,
but it's not a good thing. This would've been caught if anyone had
thought to run the amvalidate functions on the updated extension.
I think I will go and put a call to that into the regression tests of
all the contrib modules that define new opclasses.
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Kuntal Ghosh||Date: 2016-11-29 19:19:13|
|Subject: Re: Patch: Implement failover on libpq connect level.|
|Previous:||From: Robert Haas||Date: 2016-11-29 19:04:40|
|Subject: Re: XactLockTableWait doesn't set wait_event correctly|