Possible typo in nodeAgg.c

From: "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Possible typo in nodeAgg.c
Date: 2020-10-16 09:03:52
Message-ID: 7065ae4343494632bdd3ac7226d52ae6@G08CNEXMBPEKD05.g08.fujitsu.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

In /src/backend/executor/nodeAgg.c

I found the following comment still use work mem,
Since hash_mem has been introduced, Is it more accurate to use hash_mem here ?

@@ -1827,7 +1827,7 @@ hash_agg_set_limits(double hashentrysize, double input_groups, int used_bits,
/*
* Don't set the limit below 3/4 of hash_mem. In that case, we are at the
* minimum number of partitions, so we aren't going to dramatically exceed
- * work mem anyway.
+ * hash_mem anyway.

Best regards,
houzj

Attachment Content-Type Size
0001-fix-typo-in-nodeAgg.c.patch application/octet-stream 876 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2020-10-16 09:07:34 Re: [PATCH] Add extra statistics to explain for Nested Loop
Previous Message Kyotaro Horiguchi 2020-10-16 09:00:33 Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.