Re: new heapcheck contrib module

From: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: new heapcheck contrib module
Date: 2021-02-02 23:10:34
Message-ID: 70655DF3-33CE-4527-9A4D-DDEB582B6BA0@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Jan 31, 2021, at 4:05 PM, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
>
> Attached is patch set 35.

I found some things to improve in the v35 patch set. Please find attached the v36 patch set, which differs from v35 in the following ways:

0001 -- no changes

0002 -- fixing omissions in @pgfeutilsfiles in file src/tools/msvc/Mkvcbuild.pm

0003 -- no changes

0004:
-- Fixes handling of amcheck contrib module installed in non-default schema.
-- Adds database name to corruption messages to make identifying the relation being complained about unambiguous in multi-database checks
-- Fixes an instance where pg_amcheck was querying pg_database without schema-qualifying it
-- Simplifying some functions in pg_amcheck.c
-- Updating a comment to reflect the renaming of a variable that the comment mentioned by name

0005 -- fixes =pod added in PostgresNode.pm. The =pod was grammatically correct so far I can tell, but rendered strangely in perldoc.

Attachment Content-Type Size
v36-0001-Refactoring-processSQLNamePattern.patch application/octet-stream 10.7 KB
v36-0002-Moving-code-from-src-bin-scripts-to-fe_utils.patch application/octet-stream 35.4 KB
v36-0003-Parameterizing-parallel-slot-result-handling.patch application/octet-stream 11.3 KB
v36-0004-Adding-contrib-module-pg_amcheck.patch application/octet-stream 132.6 KB
v36-0005-Extending-PostgresNode-to-test-corruption.patch application/octet-stream 16.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-02-02 23:19:19 Re: LogwrtResult contended spinlock
Previous Message Jacob Champion 2021-02-02 22:22:49 Re: Proposal: Save user's original authenticated identity for logging