Re: implicit declaration of datumIsEqual in parse_coerce.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: implicit declaration of datumIsEqual in parse_coerce.c
Date: 2020-04-08 02:39:30
Message-ID: 7063.1586313570@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Tue, Apr 07, 2020 at 05:16:58PM -0400, Tom Lane wrote:
>> That's inside "#ifdef RANDOMIZE_ALLOCATED_MEMORY", which probably
>> explains why most of us aren't seeing it. My guess is somebody
>> removed an #include without realizing that this chunk of code
>> needed it.

> [cough]

Bleagh. Either of you want to put it back? (Maybe with a comment
this time, like "needed for datumIsEqual()".)

Curiously, there are no buildfarm warnings about this, even though we have
at least one member running with RANDOMIZE_ALLOCATED_MEMORY. Wonder why?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2020-04-08 02:53:44 Re: d25ea01275 and partitionwise join
Previous Message Etsuro Fujita 2020-04-08 02:37:45 Re: d25ea01275 and partitionwise join