Re: [PATCH] Add min() and max() aggregate functions for xid8

On 2022/02/09 8:49, Ken Kato wrote:
> On 2022-02-08 23:16, Fujii Masao wrote:
>> If you want to avoid the line longer than 80 columns, you should break
>> it into two or more rather than remove the test code, I think. What to
>> test is more important than formatting.
>>
>> Also the following descriptions about formatting would be helpful.
>>
>> ---------------------------
>> https://www.postgresql.org/docs/devel/source-format.html
>>
>> Limit line lengths so that the code is readable in an 80-column window.
>> (This doesn't mean that you must never go past 80 columns. For instance,
>> breaking a long error message string in arbitrary places just to keep
>> the code within 80 columns is probably not a net gain in readability.)
>> ---------------------------
>>
>> Therefore I'm ok with the patch that I posted upthread. Also I'm ok if
>> you will break that longer line into two and post new patch. Or if the
>> value '010' is really useless for the test purpose, I'm also ok if you
>> remove it. Thought?
>
> Thank you for the explanation!
>
> Even though the line is over 80 characters, it makes more sense to put in one line and it enhances readability IMO.
> Also, '010' is good to have since it is the only octal value in the test.
>
> Therefore, I think min_max_aggregates_for_xid8_v4.patch is the best one to go.

Agreed. So barring any objection, I will commit that patch.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION