Re: Prevent printing "next step instructions" in initdb and pg_upgrade

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Prevent printing "next step instructions" in initdb and pg_upgrade
Date: 2021-02-08 17:56:01
Message-ID: 703378.1612806961@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>> On Sun, Feb 7, 2021 at 11:21:05AM +0100, Magnus Hagander wrote:
>>> Isn't the whole "Success." at the end redundant here, and we should
>>> just end the message after the pg_ctl command? So not just the extra
>>> newline, but the whole thing?

>> Agreed.

> +1

In fact, I just noticed that none of our back branches print that
extra "Success." either. So that's a bug, is what it is.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-02-08 18:00:37 Re: pg_replication_origin_drop API potential race condition
Previous Message Euler Taveira 2021-02-08 16:51:08 Re: pg_replication_origin_drop API potential race condition