Re: [PATCH] Patch to make pg_hba.conf handle virtualhost access control and samehost keyword

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Damien Clermonté <damien(dot)clermonte(at)free(dot)fr>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] Patch to make pg_hba.conf handle virtualhost access control and samehost keyword
Date: 2001-07-08 20:49:36
Message-ID: 7000.994625376@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> I never figured pg_hba.conf was complex. It's one of the simplest
> configuration files I've seen. What makes it look complex is that it
> begins with 700 lines explaining it, obscuring the actual content.

Now now, it's only ~ 200 lines of comments. However...

Since pg_hba.conf is re-read on every connection, I've always thought
it was pretty bogus to bulk it up with that much internal documentation.
I've not tried to measure how much time it takes the postmaster to skip
over those 200 comment lines, but it can't be completely negligible.

I'd favor reducing the in-the-file docs to about one line saying "See
such-and-such-a-place in the documentation". Or a README. Or
something.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2001-07-08 20:50:21 Happy Anniversary
Previous Message Bruce Momjian 2001-07-08 20:14:28 Re: [PATCH] Patch to make pg_hba.conf handle virtualhost access control and samehost keyword

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2001-07-08 22:15:31 Re: [PATCH] Patch to make pg_hba.conf handle virtualhost access control and samehost keyword
Previous Message Bruce Momjian 2001-07-08 20:14:28 Re: [PATCH] Patch to make pg_hba.conf handle virtualhost access control and samehost keyword