Re: small cleanup of ICU includes

From: Andres Freund <andres(at)anarazel(dot)de>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: small cleanup of ICU includes
Date: 2026-01-06 23:20:00
Message-ID: 6inuxahcqdviyk5dssiicehg7akrdg5krwnxgrtthnyof4ujaz@uldw6cxp2c74
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2026-01-06 15:11:13 -0800, Jeff Davis wrote:
> Removes ICU includes from pg_locale.h, and instead include them in the
> few C files that need them.
>
> There used to be more files that needed to use ICU functions, but after
> refactoring, there are only a few files that access ICU APIs directly.

Yay! I think this is a pretty significant improvement, removing the need for
the ugly C++ compat hackery we had introduced, as well as (imo) just being
cleaner.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2026-01-06 23:43:27 Re: Proposal: Conflict log history table for Logical Replication
Previous Message Andres Freund 2026-01-06 23:17:50 Re: RFC: adding pytest as a supported test framework