| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | Sergei Patiakin <sergei(dot)patiakin(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Inconsistent trigger behavior between two temporal leftovers |
| Date: | 2026-06-04 09:18:24 |
| Message-ID: | 6f0b82b0-4084-4bc8-95b2-237945d35e0a@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05.05.26 23:48, Paul A Jungwirth wrote:
> On Tue, May 5, 2026 at 2:16 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>>
>> + /*
>> + * Re-copy the original row into leftoverSlot because
>> + * ExecInsert may pass leftoverSlot to BEFORE INSERT
>> + * triggers, which can modify the slot contents.
>> + */
>>
>> Shouldn't this mention BEFORE ROW INSERT triggers? Everywhere else the
>> comments/commit message/test is specific about this.
>
> I agree being specific is helpful. Here is an updated patch.
committed
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2026-06-04 09:20:07 | Re: Row pattern recognition |
| Previous Message | shveta malik | 2026-06-04 09:17:35 | Re: Proposal: Conflict log history table for Logical Replication |