Re: What is a typical precision of gettimeofday()?

From: Bernd Helmle <mailings(at)oopsware(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hannu Krosing <hannuk(at)google(dot)com>
Cc: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: What is a typical precision of gettimeofday()?
Date: 2025-07-11 09:56:28
Message-ID: 6f024eaa7885eddf5e0eb4ba1d095fbc7146519b.camel@oopsware.de
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Am Dienstag, dem 08.07.2025 um 11:25 -0400 schrieb Tom Lane:
> Hannu Krosing <hannuk(at)google(dot)com> writes:
> > On Mon, Jul 7, 2025 at 11:38 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > > What do you think of instead specifying the limit as the maximum
> > > running-percentage to print, with a default of say 99.99%?  That
> > > gives me results like
>
> > I agree that percentage covered is a much better metric indeed.
> > And I am equally ok with a default of either 99.9% or 99.99%.
>
> OK, pushed after a bit more fooling with the documentation.

FYI, since this commit TAP test pg_test_timing/001_basic on my machine
with de_DE.UTF8 locale keeps failing with:

stderr:
# Failed test 'pg_test_timing: sanity check: matches'

[...]

# Observed timing durations up to 99,9900%:
# ns % of total running % count
# 20 60,2761 60,2761 25185754
# 21 2,3724 62,6485 991291
# 30 35,0016 97,6501 14625052
# 31 2,1129 99,7631 882874
# 40 0,2038 99,9669 85169
# 41 0,0166 99,9835 6933
# 50 0,0086 99,9921 3584
# ...
# 230806 0,0000 100,0000 1
# '
# doesn't match '(?^sx:
# Testing\ timing\ overhead\ for\ 1\ second\..*
# Histogram\ of\ timing\ durations\:.*
# Observed\ timing\ durations\ up\ to\ 99\.9900\%\:
# )'
# Looks like you failed 1 test of 18.

(test program exited with status code 1)

Of course this is because of the localized comma in 99,9900%, as
executing with

LANG=C meson test -q --print-errorlogs pg_test_timing/001_basic

let this test succeed.

Bernd

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Japin Li 2025-07-11 09:58:15 Re: track needed attributes in plan nodes for executor use
Previous Message Laurenz Albe 2025-07-11 09:51:30 Re: analyze-in-stages post upgrade questions