Re: Remove useless casting to the same type

On 24.11.25 11:26, Bertrand Drouvot wrote:
> Hi hackers,
>
> Attached is a patch to $SUBJECT.
>
> This is the same kind of idea as 7f798aca1d5 and ef8fe693606, as their presence
> could cause risks of hiding actual type mismatches in the future or silently
> discarding qualifiers. I think that it also improves readability.
>
> Those have been found with a coccinelle script as:
>
> "
> @@
> type T;
> T E;
> @@
>
> - (T)
> E
> "
>
> which removes casts when it's casting to the same type.
>
> Note that it generated more that what is in the attached. I chose not to remove
> some of them (mainly arithmetic ones) to keep the patch focused on what matters
> here.

Committed. I made some cosmetic adjustments, to remove line breaks that
are no longer necessary with the shortened lines, and in gbt_num_union()
I kept &out[0] (instead of just out) for consistency with the following
line.