| From: | Oskari Saarenmaa <os(at)aiven(dot)io> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Tripp <peter(at)chartio(dot)com>, Virendra Negi <virendra(at)idyllic-software(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #14150: Attempted to delete invisible tuple |
| Date: | 2016-07-07 19:43:59 |
| Message-ID: | 6e259534-eb94-0319-dace-ee83d9535a86@aiven.io |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
07.07.2016, 05:15, Peter Geoghegan kirjoitti:
> Maybe heap_abort_speculative() should be refactored to call another
> function, and keep only the parts that specifically expect a
> HeapTupleHeaderIsSpeculative() tuple. The function that it is made to
> call (that consists of the majority of the current
> heap_abort_speculative() implementation) could also be called by a
> special super deletion variant of toast_delete(). No need to spread
> knowledge about speculative insertion any further this way, AFAICT.
> The UPSERT commit did modify two HeapTupleSatisfies* routines, but
> that didn't include HeapTupleSatisfiesUpdate() (just
> HeapTupleSatisfiesDirty(), and the aforementioned defensive code in
> HeapTupleSatisfiesToast()).
>
> What do you think of this outline, Oskari and Andres?
Something like the attached patch? It still modifies the toast_delete
API, but we could also implement a new speculative-tuple-aware version
of it if that's a concern.
/ Oskari
| Attachment | Content-Type | Size |
|---|---|---|
| heap_delete_speculative.patch | text/x-patch | 4.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2016-07-07 20:44:31 | Re: BUG #14233: getting the size if the database failing with permission denied error |
| Previous Message | bricklen | 2016-07-07 16:10:02 | Re: Where clause in pg_dump: need help |