Re: TM format can mix encodings in to_char()

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: TM format can mix encodings in to_char()
Date: 2019-04-21 13:25:48
Message-ID: 6e016924-bcf2-47c4-c4db-2428088cde12@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 4/21/19 12:28 AM, Tom Lane wrote:
> I wrote:
>> [ fix-encoding-and-error-recovery-in-cache-locale-time.patch ]
> On closer inspection, I'm pretty sure either version of this patch
> will break things on Windows, because that platform already had code
> to convert the result of wcsftime() to the database encoding; we
> were adding code to do a second conversion, which will not go well.
>
> The attached revised patch deletes the no-longer-necessary
> platform-specific recoding stanza, in favor of having cache_locale_time
> know that it's getting UTF8 rather than something else. I also
> updated a bunch of the related comments.
>
> I don't have any way to test this on Windows, so could somebody
> do that? Manually running the Turkish test cases ought to be enough.
>
>

How does one do that? Just set a Turkish locale?

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-04-21 14:21:19 Re: TM format can mix encodings in to_char()
Previous Message 梦旅人 2019-04-21 12:32:30 Do PostgreSQL have map and set structure(like STL in C++)?