| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | steven(dot)winfield(at)cantabcapital(dot)com |
| Subject: | Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes |
| Date: | 2020-01-03 07:54:35 |
| Message-ID: | 6ccd23e4-ce58-c2b5-39a1-801a9937ae86@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 2019-11-03 23:40, Tom Lane wrote:
> * The patch now always quotes completed filenames, so quote_if_needed()
> is misnamed and overcomplicated for this use-case. I left the extra
> generality in place for possible future use. On the other hand, this
> is the*only* use-case, so you could also argue that we should just
> simplify the function's API. I have no strong opinion about that.
I haven't found an explanation in this thread why it does always quote
now. That seems a bit unusual. Is there a reason for this? Can we do
without it?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-01-03 13:37:37 | Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes |
| Previous Message | Zhihong Zhang | 2020-01-02 22:30:23 | Re: Indexing on JSONB field not working |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-01-03 08:01:58 | Re: parallel vacuum options/syntax |
| Previous Message | Amit Kapila | 2020-01-03 07:24:56 | Re: [PATCH] Fix parallel query doc typos |