| From: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | surya poondla <suryapoondla4(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Prashant Chinnam <crprashant(at)hotmail(dot)com>, peter(at)eisentraut(dot)org, Mahendrakar Srinivasarao <mahendrakarforpg(at)gmail(dot)com> |
| Subject: | Re: extension_control_path: ignore empty elements and deduplicate directories |
| Date: | 2026-11-11 18:54:24 |
| Message-ID: | 6cc26872-dfda-42f1-9b79-4001e58f71fd@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/11/26 16:27, Matheus Alcantara wrote:
> Regarding the backpatch, I don't think that having a different behaviour
> on master and on the back branches is a good idea. If '$system:' raises
> an error on 20 but is silently ignored on 18 and 19, the same setting
> behaves differently depending on the version, which seems confusing to
> me, especially for a parameter that was only introduced on 18. I think
> that we should either raise the error on all branches or silently ignore
> the empty elements on all branches, and then backpatch whichever we
> choose. (CCing Peter so we can get a committer thought on this).
>
I talked with Peter off list and it seems that just silently ignore
the error is the better approach to take here.
We currently don't raise an error for non-existing paths so I think
that it's ok to just ignore non-applicable path elements.
--
Matheus Alcantara
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-11-11 19:11:07 | Re: Two bugs in reconsider_full_join_clause(), handling coalesce() = const clauses |
| Previous Message | Kirill Reshke | 2026-11-11 18:49:37 | Re: Two bugs in reconsider_full_join_clause(), handling coalesce() = const clauses |