| From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrey Borodin <amborodin86(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Add pretty-printed XML output option |
| Date: | 2023-02-23 06:36:16 |
| Message-ID: | 6cb296fe-4b49-3691-633e-2e2366997b04@uni-muenster.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23.02.23 02:52, Peter Smith wrote:
> Here are my review comments for patch v17-0001.
>
> ======
> src/test/regress/sql/xml.sql
>
> The blank line(s) which previously separated the xmlserialize tests
> from the xml IS [NOT] DOCUMENT tests are now missing...
v18 adds a new line in the xml.sql file to separate the xmlserialize
test cases from the rest.
Thanks!
Best, Jim
| Attachment | Content-Type | Size |
|---|---|---|
| v18-0001-Add-pretty-printed-XML-output-option.patch | text/x-patch | 24.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2023-02-23 07:30:08 | Re: Add SHELL_EXIT_CODE to psql |
| Previous Message | Tom Lane | 2023-02-23 04:48:49 | Re: pgindent vs. git whitespace check |