Re: Prevent object capture in CREATE/ALTER EXTENSION scripts

Hi Hackers,

To confirm the patch works with existing extensions, I ran additional
tests. I installed various extensions on both a patched and an unpatched
server. I tested contrib and src/test/modules on master (95 extensions),
and all postgresql-18-* packages from apt.postgresql.org plus contrib
(171 extensions) on a backport of this patch to 18.6 (since there are no
extension packages for master).

I installed each extension as a superuser and, when possible (trusted or
superuser = false), also as a non-superuser. I also did this in
databases that already had objects owned by a non-superuser. I updated
extensions from older versions to the current one and repeated the
installs with debug_parallel_query set to regress. Only a few scripts
actually ran queries in parallel workers, and they behaved the same on
both servers. For each run, I compared the results of every statement
and checked which objects the extension's members pointed to using
pg_depend.

I found no differences between the patched and unpatched servers. The
regression tests for contrib and 35 third-party extensions also gave the
same results. For the third-party regression tests, I only included
extensions that run their tests with a plain PGXS "make installcheck".

I'm happy to share the scripts I used if anyone wants to rerun the tests.

Best regards
Jan

--
Jan Nidzwetzki
PlanetScale