| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] What does it mean by XLOG_BACKUP_RECORD? |
| Date: | 2017-12-08 16:25:07 |
| Message-ID: | 6b962e5a-2d54-01fb-85da-463fbbb3a374@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/29/17 06:09, Masahiko Sawada wrote:
> Thanks, I agree to use XLOG_BACKUP_END instead.
>
>> Worse, the current comment implies that
>> minRecoveryPoint is incorrectly set if it is true. Bleh.
>
> Looking at the condition, we use minRecoveryPoint only when
> ControlFile->backupEndRequired is *false*. So I guess that it means
> that minRecoveryPoint is incorrectly set if
> ControlFile->backupEndReuired is true. Am I missing something?
I agree with you that the logic in the comment is correct. I've
committed just the symbol change.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vladimir Svedov | 2017-12-08 16:26:46 | Re: proposal: alternative psql commands quit and exit |
| Previous Message | Robert Haas | 2017-12-08 16:15:25 | Re: [HACKERS] parallel.c oblivion of worker-startup failures |