| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robbie Harwood <rharwood(at)redhat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: cfbot run pgindent? |
| Date: | 2018-12-18 21:08:33 |
| Message-ID: | 6b834dc2-ac96-6960-84c2-edaa341eb45d@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 18/12/2018 19:50, Robbie Harwood wrote:
> Second, since the project does have a defined style checker, do you
> think it would be possible to run it as part of cfbot and report errors?
pgindent is a code formatter, not a style checker. Using it to check
whether just the newly added code is correctly formatted would probably
require that all existing code is correctly formatted at all times,
which isn't the case.
What cfbot could do is spit out a diff at the end between the current
code and the pgindent'ed version. That might be useful in some cases.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-12-18 21:12:05 | WRITE_*_ARRAY macros for outfuncs.c |
| Previous Message | Alvaro Herrera | 2018-12-18 21:01:59 | Re: [HACKERS] CLUSTER command progress monitor |