| From: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Record queryid when auto_explain.log_verbose is on |
| Date: | 2023-03-07 02:18:29 |
| Message-ID: | 6af4aec42d2b5bf9be63453a0e0caf74@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-03-07 08:50, Imseih (AWS), Sami wrote:
> I am wondering if this patch should be backpatched?
>
> The reason being is in auto_explain documentation [1],
> there is a claim of equivalence of the auto_explain.log_verbose
> option and EXPLAIN(verbose)
>
> "..... it's equivalent to the VERBOSE option of EXPLAIN."
>
> This can be quite confusing for users of the extension.
> The documentation should either be updated or a backpatch
> all the way down to 14, which the version the query identifier
> was moved to core. I am in favor of the latter.
>
> Any thoughts?
We discussed a bit whether to backpatch this, but agreed that it would
be better not to do so for the following reasons:
> It's a bit annoying that the info is missing since pg 14, but we
> probably can't
> backpatch this as it might break log parser tools.
What do you think?
--
Regards,
--
Atsushi Torikoshi
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-03-07 02:42:03 | Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes? |
| Previous Message | Kyotaro Horiguchi | 2023-03-07 02:17:45 | Re: Add pg_walinspect function with block info columns |