Re: BUG #8531: systemtap probe mark(checkpoint__done) error when i read the parameters

HI,

But the CHECKPOINT_DONE used in src have parameters:
CheckpointStats.ckpt_bufs_written,
NBuffers,
CheckpointStats.ckpt_segs_added,
CheckpointStats.ckpt_segs_removed,
CheckpointStats.ckpt_segs_recycled

probes.h
/* TRACE_POSTGRESQL_CHECKPOINT_DONE ( int, int, int, int, int) */
#if defined STAP_SDT_V1
#define TRACE_POSTGRESQL_CHECKPOINT_DONE_ENABLED() __builtin_expect (checkpoint__done_semaphore, 0)
#define postgresql_checkpoint__done_semaphore checkpoint__done_semaphore
#else
#define TRACE_POSTGRESQL_CHECKPOINT_DONE_ENABLED() __builtin_expect (postgresql_checkpoint__done_semaphore, 0)
#endif
__extension__ extern unsigned short postgresql_checkpoint__done_semaphore __attribute__ ((unused)) __attribute__ ((section (".probes")));
#define TRACE_POSTGRESQL_CHECKPOINT_DONE(arg1,arg2,arg3,arg4,arg5) \
DTRACE_PROBE5(postgresql,checkpoint__done,arg1,arg2,arg3,arg4,arg5)

src/backend/access/transam/xlog.c
TRACE_POSTGRESQL_CHECKPOINT_DONE(CheckpointStats.ckpt_bufs_written,
NBuffers,
CheckpointStats.ckpt_segs_added,
CheckpointStats.ckpt_segs_removed,
CheckpointStats.ckpt_segs_recycled);

and PostgreSQL Document:

| checkpoint-done | (int, int, int, int, int) | Probe that fires when a checkpoint is complete. (The probes listed next fire in sequence during checkpoint processing.) arg0 is the number of buffers written. arg1 is the total number of buffers. arg2, arg3 and arg4 contain the number of xlog file(s) added, removed and recycled respectively. |

--
公益是一辈子的事,I'm Digoal,Just Do It.

At 2013-10-17 23:47:54,"Alvaro Herrera" <alvherre(at)2ndquadrant(dot)com> wrote:
>digoal(at)126(dot)com wrote:
>
>> When i probe checkpoint__done, and read the parameters , it's error:
>
>CHECKPOINT_DONE doesn't have parameters. It works for CHECKPOINT_START
>because that one has one parameter.
>
>--
>Álvaro Herrera http://www.2ndQuadrant.com/
>PostgreSQL Development, 24x7 Support, Training & Services