Re: Error-like LOG when connecting with SSL for password authentication

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Vaishnavi Prabakaran <vaishnaviprabakaran(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Error-like LOG when connecting with SSL for password authentication
Date: 2017-05-23 10:36:02
Message-ID: 6a611c33-918a-510a-212d-f156559c8592@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05/22/2017 10:11 PM, Vaishnavi Prabakaran wrote:
> On Mon, May 22, 2017 at 5:10 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
> wrote:
>
>> If the protocol version is SSL
>> 3.0 or TLS 1.0, this result code is returned only if a closure alert
>> has occurred in the protocol, i.e. if the connection has been closed
>> cleanly. Note that in this case SSL_ERROR_ZERO_RETURN does not
>> necessarily indicate that the underlying transport has been closed.
>
> I guess this error code exist even for SSL2 protocol, In that case, don't
> we need to keep the current code for this error code?

If I understand correctly, with SSLv2, SSL_ERROR_ZERO_RETURN does mean
that the underlying transport has been closed. Returning 0 seems
appropriate in that case, too.

But the point is moot anyway, because PostgreSQL doesn't allow SSLv2
anymore.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mahi Gurram 2017-05-23 10:42:03 Regarding Postgres Dynamic Shared Memory (DSA)
Previous Message Heikki Linnakangas 2017-05-23 10:26:12 Re: Error-like LOG when connecting with SSL for password authentication