| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, "Nathan Bossart" <nathandbossart(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: split tablecmds.c |
| Date: | 2025-12-01 19:13:22 |
| Message-ID: | 6a119f95-2309-464f-89d1-e17ff42a1a67@app.fastmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 1, 2025, at 3:18 PM, Álvaro Herrera wrote:
> My first thought would be to move code that deals with catalog changes
> to files in catalog/. Also a couple of functions related to tablespaces
> could be perhaps be moved to commands/tablespace.c.
>
As Tom said partitioning has a big chunk of lines of code. I bet that's the
biggest portion. It seems a good candidate to be moved to a new file
(partitioning and inheritance). Besides your suggestion, I would add things
that set properties (RLS, reloptions, AM, replica identity, generated columns)
to another file (tableutils.c?).
--
Euler Taveira
EDB https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2025-12-01 19:14:57 | Re: Dynamic shared memory areas |
| Previous Message | Tom Lane | 2025-12-01 18:59:01 | Re: split tablecmds.c |